Add scope Booking wrappers#476
Draft
fatestr1ngs wants to merge 1 commit into
Draft
Conversation
mesilov
requested changes
May 25, 2026
mesilov
left a comment
Collaborator
There was a problem hiding this comment.
please
- update branch from v3-dev
- resolve comments
| /** | ||
| * This file is part of the bitrix24-php-sdk package. | ||
| * | ||
| * © Maksim Mesilov <mesilov.maxim@gmail.com> |
Collaborator
There was a problem hiding this comment.
Please add your full name and contacts
| * @property-read array<string, mixed>|null $datePeriod | ||
| * @property-read array<int, int>|null $resourceIds | ||
| */ | ||
| class BookingItemResult extends AbstractItem |
Collaborator
There was a problem hiding this comment.
in 3.2.0 we added https://github.com/bitrix24/b24phpsdk/blob/v3/src/Core/Result/AbstractAnnotatedItem.php#L22C16-L22C37 with automatic type casting based on phpdocs annotations
please fix
class BookingItemResult extends AbstractItem
to
class BookingItemResult extends AbstractAnnotatedItem
| * @property-read int|null $id | ||
| * @property-read array<string, string>|null $type | ||
| */ | ||
| class BookingClientItemResult extends AbstractItem |
Collaborator
There was a problem hiding this comment.
| * @property-read string|null $moduleId | ||
| * @property-read string|null $value | ||
| */ | ||
| class BookingExternalDataItemResult extends AbstractItem |
Collaborator
There was a problem hiding this comment.
9 tasks
23c325c to
c497f17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Booking scope in the PHP SDK.
Example usage:
Quality-gate checklist
Closes #473